Skip to content

fix: timezone variable name does not match webhook payload#24279

Merged
anikdhabal merged 1 commit intocalcom:mainfrom
Kinbaum:fix-webhook-payload
Oct 6, 2025
Merged

fix: timezone variable name does not match webhook payload#24279
anikdhabal merged 1 commit intocalcom:mainfrom
Kinbaum:fix-webhook-payload

Conversation

@Kinbaum
Copy link
Contributor

@Kinbaum Kinbaum commented Oct 5, 2025

What does this PR do?

Fixes an issue with the custom webhook payload. The data is returned as attendees.0.timeZone but the variable name when constructing a custom payload suggests attendees.0.timezone (note the lowercase)

Visual Demo (For contributors especially)

CleanShot 2025-10-05 at 11 22 11@2x

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Add console log to your API and observe the payload coming from cal.com
  • Trigger a ping test to see the default payload

You will see the following payload

{
  triggerEvent: 'PING',
  createdAt: '2025-10-05T15:28:45.646Z',
  payload: {
    type: 'Test',
    title: 'Test trigger event',
    startTime: '2025-10-05T15:28:45.646Z',
    endTime: '2025-10-05T15:28:45.646Z',
    attendees: [
      {
        email: 'jdoe@example.com',
        name: 'John Doe',
        timeZone: 'Europe/London', // See the time zone here is capitalized
        language: { locale: 'en' },
        utcOffset: 60
      }
    ],
    organizer: {
      name: 'Cal',
      email: 'no-reply@cal.com',
      timeZone: 'Europe/London',
      language: { locale: 'en' },
      utcOffset: 60
    }
  }
}

@vercel
Copy link

vercel bot commented Oct 5, 2025

@Kinbaum is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 5, 2025
@graphite-app graphite-app bot requested a review from a team October 5, 2025 15:30
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

Renames the attendee timezone variable key in packages/features/webhooks/components/WebhookForm.tsx from attendees.0.timezone to attendees.0.timeZone, and updates the corresponding template placeholder from {{attendees.0.timezone}} to {{attendees.0.timeZone}}. No other fields or logic are changed.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely describes the primary change by indicating a fix for the timezone variable name mismatch in the webhook payload, accurately reflecting the core update without extraneous details.
Description Check ✅ Passed The pull request description clearly states the mismatch between the returned timeZone field and the expected timezone variable in custom payloads and directly relates to the changes adjusting this key, demonstrating an accurate understanding of the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added webhooks area: webhooks, callback, webhook payload 🐛 bug Something isn't working labels Oct 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

E2E results are ready!

@anikdhabal anikdhabal merged commit 55ea181 into calcom:main Oct 6, 2025
115 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e size/XS webhooks area: webhooks, callback, webhook payload

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants