fix: week view and column view slots not fetching at end of month bug by Ryukemeister · Pull Request #24374 · calcom/cal.com

Ryukemeister · 2025-10-08T20:51:05Z

No description provided.

…r store instead

coderabbitai · 2025-10-08T20:52:06Z

Walkthrough

BookerWebWrapper: selectedDate source changed from URL parameter to state.selectedDate via useBookerStoreContext; downstream formatting uses this store value.
CalendarViewPlatformWrapper: introduced usePrefetch to supply prefetchNextMonth and monthCount; removed in-component prefetch calculations. Removed view prop and related layout logic; initialization now passes a fixed layout value "week_view". Updated data flow to remove dependence on previous layout-derived variables and mapping.

Possibly related PRs

fix: Platform Prefetch for slots due to NaN != NaN issue #23913: Replaces inline month-prefetch logic with the shared usePrefetch hook in similar wrappers.
feat: calendar view atom v1 #23840: Adjusts calendar-view platform wrappers and selectedDate setup, aligning with fixed layout and initialization changes.
fix: multiple widgets for Booker atom #22925: Migrates Booker to a context-backed store and introduces useBookerStoreContext, matching the new selectedDate sourcing.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request does not include any description to explain the changes or context, so there is no information about the scope or details of the fix.	Please add a concise description outlining the bug being fixed, the affected components, and an overview of the implemented changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and succinctly identifies the specific bug being fixed in week and column views at month end, follows conventional commit style, and directly reflects the main purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-week-view-bug

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bec49ef and 99055fe.

📒 Files selected for processing (2)

packages/platform/atoms/booker/BookerWebWrapper.tsx (1 hunks)
packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx (3 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

packages/platform/atoms/booker/BookerWebWrapper.tsx
packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

packages/platform/atoms/booker/BookerWebWrapper.tsx
packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

packages/platform/atoms/booker/BookerWebWrapper.tsx
packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

🧠 Learnings (2)

📚 Learning: 2025-09-18T13:38:50.958Z

Learnt from: hariombalhara
PR: calcom/cal.com#23913
File: packages/features/bookings/Booker/components/hooks/usePrefetch.ts:43-50
Timestamp: 2025-09-18T13:38:50.958Z
Learning: In usePrefetch hook in packages/features/bookings/Booker/components/hooks/usePrefetch.ts, the !isNaN() checks before comparing monthAfterAdding1Month !== monthAfterAddingExtraDaysColumnView are intentional to prevent the NaN !== NaN issue where NaN values would incorrectly be considered different, leading to wrong monthCount calculations.

Applied to files:

packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

📚 Learning: 2025-07-15T12:59:34.389Z

Learnt from: eunjae-lee
PR: calcom/cal.com#22106
File: packages/features/insights/components/FailedBookingsByField.tsx:65-71
Timestamp: 2025-07-15T12:59:34.389Z
Learning: In the FailedBookingsByField component (packages/features/insights/components/FailedBookingsByField.tsx), although routingFormId is typed as optional in useInsightsParameters, the system automatically enforces a routing form filter, so routingFormId is always present in practice. This means the data always contains only one entry, making the single-entry destructuring approach safe.

Applied to files:

packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

🧬 Code graph analysis (2)

packages/platform/atoms/booker/BookerWebWrapper.tsx (1)

packages/features/bookings/Booker/BookerStoreProvider.tsx (1)

useBookerStoreContext (24-35)

packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx (1)

packages/features/bookings/Booker/components/hooks/usePrefetch.ts (1)

usePrefetch (16-56)

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Install dependencies / Yarn install & cache

🔇 Additional comments (3)

packages/platform/atoms/booker/BookerWebWrapper.tsx (1)

58-58: LGTM! Store context resolves param detection issue.

Reading selectedDate from the Booker store context instead of URL parameters correctly addresses the NextJS param update detection issue mentioned in the past review comment. This ensures the selected date stays synchronized with the store state.

packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx (2)

14-14: LGTM! Centralized prefetch logic.

The usePrefetch hook correctly centralizes the month/prefetch calculations. The hook receives the proper parameters (date, month, bookerLayout, bookerState) and the returned values (prefetchNextMonth, monthCount) are correctly consumed by useTimesForSchedule at lines 85-91. This should fix the end-of-month slot fetching issue mentioned in the PR title.

Based on learnings: The NaN checks in usePrefetch (from the relevant code snippet) are intentional to handle the NaN !== NaN comparison issue when calculating monthCount.

Also applies to: 78-83

148-148: LGTM! Fixed layout is intentional.

Hardcoding the layout to "week_view" is correct for this calendar view wrapper, as confirmed by the past review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vercel · 2025-10-09T07:33:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
cal	Ignored			Oct 9, 2025 9:49am
cal-eu	Ignored			Oct 9, 2025 9:49am

Ryukemeister · 2025-10-09T09:48:48Z

packages/platform/atoms/booker/BookerWebWrapper.tsx


  const bookerLayout = useBookerLayout(event.data?.profile?.bookerLayouts);
-  const selectedDate = searchParams?.get("date");
+  const selectedDate = useBookerStoreContext((state) => state.selectedDate);


there is an issue with this approach, what happens is we pick date from search params and that value is correct, but when the params are updated nextjs is not able to detect this param updation so the value of selectedDate never changes. hence we can use selectedDate from useBookerStoreContext instead

Ryukemeister · 2025-10-09T09:49:24Z

packages/platform/atoms/calendar-view/wrappers/CalendarViewPlatformWrapper.tsx

    rescheduleUid: props.rescheduleUid ?? null,
    bookingUid: props.bookingUid ?? null,
-    layout: layout,
+    layout: "week_view",


we know this is always gonna be week view hence we hardcode the layout as week_view

supalarry

Great fix!

github-actions · 2025-10-09T10:48:01Z

E2E results are ready!

Workflow #82516.1 latest results

emrysal

Looks good to me 👍

…#24374) * fix: dont pick date value from url, use selectedDate value from booker store instead * fix: replace month count logic with usePrefectch hook * intialise booker layout as week view

fix: dont pick date value from url, use selectedDate value from booke…

cc584b2

…r store instead

pull-request-size bot added the size/XS label Oct 8, 2025

keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Oct 8, 2025

vercel bot deployed to Preview – dev October 8, 2025 21:10 View deployment

Merge branch 'main' into fix-week-view-bug

b8fc723

vercel bot had a problem deploying to Preview – dev October 9, 2025 08:18 Failure

fix: replace month count logic with usePrefectch hook

409821a

pull-request-size bot added size/S and removed size/XS labels Oct 9, 2025

intialise booker layout as week view

01dca70

Ryukemeister commented Oct 9, 2025

View reviewed changes

Ryukemeister marked this pull request as ready for review October 9, 2025 09:49

Ryukemeister requested a review from a team October 9, 2025 09:49

Ryukemeister requested a review from a team as a code owner October 9, 2025 09:49

Merge branch 'main' into fix-week-view-bug

99055fe

dosubot bot added the 🐛 bug Something isn't working label Oct 9, 2025

Ryukemeister requested a review from supalarry October 9, 2025 09:56

supalarry approved these changes Oct 9, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Oct 9, 2025

vercel bot had a problem deploying to Preview – dev October 9, 2025 10:59 Failure

emrysal approved these changes Oct 9, 2025

View reviewed changes

emrysal merged commit 445b307 into main Oct 9, 2025
79 of 84 checks passed

emrysal deleted the fix-week-view-bug branch October 9, 2025 12:57

coderabbitai bot mentioned this pull request Oct 13, 2025

refactor: usePrefetch hook #24123

Merged

coderabbitai bot mentioned this pull request Oct 15, 2025

fix: duplicate get schedule #24471

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: week view and column view slots not fetching at end of month bug#24374

fix: week view and column view slots not fetching at end of month bug#24374
emrysal merged 5 commits intomainfrom
fix-week-view-bug

Ryukemeister commented Oct 8, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

Ryukemeister Oct 9, 2025

Uh oh!

Ryukemeister Oct 9, 2025

Uh oh!

supalarry left a comment

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

emrysal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

Ryukemeister commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

vercel bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ryukemeister Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Ryukemeister Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

supalarry left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 9, 2025

E2E results are ready!

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ryukemeister commented Oct 8, 2025 •

edited

Loading

coderabbitai bot commented Oct 8, 2025 •

edited

Loading

vercel bot commented Oct 9, 2025 •

edited

Loading