Skip to content

Comments

fix: ESLint config in app-store and features#24387

Merged
hbjORbj merged 2 commits intomainfrom
fix/eslint-configs
Oct 9, 2025
Merged

fix: ESLint config in app-store and features#24387
hbjORbj merged 2 commits intomainfrom
fix/eslint-configs

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 9, 2025

What does this PR do?

Current behavior:

Screenshot 2025-10-09 at 10 19 26 PM
  • /features can import /app-store, but /app-store can't import /features. Currently, it's the other way around.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@graphite-app graphite-app bot requested review from a team October 9, 2025 13:18
@keithwillcode keithwillcode added core area: core, team members only foundation labels Oct 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updated packages/app-store/eslint.config.mjs to change the ESLint forbid rule’s exclusion from "../app-store/" to "../features/". This alters which paths are excluded from the restriction. No changes to exports or other config structure.

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title directly references the correction to the ESLint configuration and identifies the relevant directories involved. It concisely describes the main focus of the changeset by noting both app-store and features contexts. This phrasing allows teammates scanning history to quickly grasp the primary purpose of the PR.
Description Check ✅ Passed The description clearly outlines the current import behavior issue, includes a screenshot for context, and specifies how the ESLint configuration will be adjusted. It directly relates to the code modifications and provides sufficient instructions for testing. Therefore, the description appropriately supports and explains the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/eslint-configs

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 445b307 and 609fba2.

📒 Files selected for processing (1)
  • packages/app-store/eslint.config.mjs (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (1)
packages/app-store/eslint.config.mjs (1)

7-7: LGTM: no imports from ../features/** found in packages/app-store—safe to merge.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hbjORbj hbjORbj changed the title fix: eslint configs fix: ESLint config in app-store and features Oct 9, 2025
@hbjORbj hbjORbj enabled auto-merge (squash) October 9, 2025 13:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

E2E results are ready!

@hbjORbj hbjORbj merged commit 8277ce9 into main Oct 9, 2025
104 of 110 checks passed
@hbjORbj hbjORbj deleted the fix/eslint-configs branch October 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants