Skip to content

fix: v2 CI breaking changes check #24445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supalarry merged 4 commits into from
Oct 14, 2025
Merged

fix: v2 CI breaking changes check #24445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e751add
fix: v2 CI breaking changes check
supalarry Oct 14, 2025
870e953
fix: ensure defaults
supalarry Oct 14, 2025
a941915
Merge branch 'main' into lauris/cal-6569-fix-ci-v2-breaking-changes-c…
supalarry Oct 14, 2025
06fea9f
fix
supalarry Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/api/v2/src/modules/teams/memberships/inputs/get-team-memberships.input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { GetUsersInput } from "@/modules/users/inputs/get-users.input";
import { ApiPropertyOptional } from "@nestjs/swagger";
import { Transform } from "class-transformer";
import { ArrayMaxSize, ArrayNotEmpty, IsEmail, IsOptional } from "class-validator";

export class GetTeamMembershipsInput extends GetUsersInput {
import { SkipTakePagination } from "@calcom/platform-types";

export class GetTeamMembershipsInput extends SkipTakePagination {
Copy link
Contributor Author

@supalarry supalarry Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetUsersInput consists of emails, skip and take and we process emails differently in GetTeamMembershipsInput and need previous skip and take so we just extend SkipTakePagination instead of GetUsersInput

@IsOptional()
@Transform(({ value }) => {
if (value == null) return undefined;
Expand Down
Loading
Loading