Skip to content

Comments

feat: [Booking Audit Stack - 6] Integration of Booking Audit System#25120

Merged
hariombalhara merged 2 commits intobooking-audit-more-infrafrom
booking-audit-all-integration
Dec 6, 2025
Merged

feat: [Booking Audit Stack - 6] Integration of Booking Audit System#25120
hariombalhara merged 2 commits intobooking-audit-more-infrafrom
booking-audit-all-integration

Conversation

@hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Nov 13, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Integrates the booking audit system end-to-end and adds a dedicated viewer service. Handlers now emit audit logs across booking creation, confirmations, cancellations, reschedules, attendee/location changes, reassignments, and no‑shows; the API returns enriched logs with linked reschedule history.

  • New Features
    • BookingAuditViewerService for permission-checked, enriched logs (actor display, displaySummary/details), with DI modules; viewer.bookings.getAuditLogs now uses it.
    • Replaced StatusChangeAuditActionService with AcceptedAuditActionService; BookingAuditService is write-only and ViewerService handles read/formatting.
    • Repository now exposes findAllForBooking returning logs for a booking and linked bookings, including actor info.
    • Actor tracking improved via user.uuid in session and repositories to attribute actions accurately.
    • Wired handlers to emit audit entries: confirmation, cancellation, request reschedule, add guests, edit location, round-robin reassignment, mark host/attendee no‑show.
    • Extended getBookingToDelete to include cancellationReason and cancelledBy to support cancellation audit data.

Written for commit 3618b5a. Summary will update automatically on new commits.

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cal-companion Error Error Nov 30, 2025 9:17am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Nov 30, 2025 9:17am
cal-eu Ignored Ignored Nov 30, 2025 9:17am

@github-actions github-actions bot added ❗️ migrations contains migration files and removed size/XXL labels Nov 13, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Nov 13, 2025
Copy link
Member Author

hariombalhara commented Nov 13, 2025

@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 4b350a6 to 8d57bc3 Compare November 13, 2025 11:21
@hariombalhara hariombalhara force-pushed the booking-audit-foundation branch from 7cad32c to 1dacbac Compare November 13, 2025 11:23
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 8d57bc3 to 4ca01d5 Compare November 13, 2025 11:23
@hariombalhara hariombalhara force-pushed the booking-audit-foundation branch from 1dacbac to 5554394 Compare November 13, 2025 11:28
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch 2 times, most recently from 0910c50 to 9aa3814 Compare November 13, 2025 11:30
@hariombalhara hariombalhara force-pushed the booking-audit-foundation branch 2 times, most recently from 751493b to a2dddaf Compare November 13, 2025 11:35
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 9aa3814 to 62b4db0 Compare November 13, 2025 11:35
@hariombalhara hariombalhara changed the base branch from booking-audit-foundation to graphite-base/25120 November 13, 2025 11:44
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 62b4db0 to b9130d7 Compare November 13, 2025 11:44
@hariombalhara hariombalhara changed the base branch from graphite-base/25120 to booking-audit-di November 13, 2025 11:44
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from b9130d7 to 3d20758 Compare November 13, 2025 12:28
@hariombalhara hariombalhara changed the base branch from booking-audit-di to graphite-base/25120 November 13, 2025 12:59
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 3d20758 to 6893787 Compare November 13, 2025 12:59
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch 2 times, most recently from a7ca540 to b8ae1ed Compare November 28, 2025 09:57
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from cf6d86c to 53aebb1 Compare November 28, 2025 09:57
@github-actions github-actions bot removed the Stale label Nov 29, 2025
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from b8ae1ed to f278b99 Compare November 29, 2025 09:41
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from 53aebb1 to cd9feec Compare November 29, 2025 09:41
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from f278b99 to 8616f03 Compare November 29, 2025 11:55
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from cd9feec to bd64fa8 Compare November 29, 2025 11:55
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 8616f03 to ac35e86 Compare November 29, 2025 12:13
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from bd64fa8 to 9a0b3c6 Compare November 29, 2025 12:13
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from 9a0b3c6 to eca38d9 Compare November 29, 2025 12:33
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from ac35e86 to 52ba832 Compare November 29, 2025 12:33
- Integrated addGuests handler with onAttendeeAdded event
- Integrated confirm handler with onBookingAccepted event
- Integrated editLocation handler with onLocationChanged event
- Integrated requestReschedule handler with onRescheduleRequested event
- Integrated handleCancelBooking with onBookingCancelled event
- Integrated handleConfirmation with onBookingAccepted event
- Integrated roundRobinManualReassignment with onReassignment event
- Integrated roundRobinReassignment with onReassignment event
- Integrated handleMarkNoShow with onAttendeeNoShowUpdated and onHostNoShowUpdated events
- Added uuid field support across repositories and handlers for proper actor tracking
- Updated getBookingToDelete to include cancellationReason and cancelledBy fields
@hariombalhara hariombalhara force-pushed the booking-audit-linkedBookingId branch from eca38d9 to ae7bc05 Compare November 30, 2025 09:08
@hariombalhara hariombalhara force-pushed the booking-audit-all-integration branch from 52ba832 to 3618b5a Compare November 30, 2025 09:08
Base automatically changed from booking-audit-linkedBookingId to booking-audit-more-infra December 6, 2025 06:24
@hariombalhara hariombalhara merged commit 5e6309f into booking-audit-more-infra Dec 6, 2025
13 of 19 checks passed
@hariombalhara hariombalhara deleted the booking-audit-all-integration branch December 6, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ❗️ migrations contains migration files size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants