fix: break circular dependency between reminderScheduler and credit-service#25312
Merged
fix: break circular dependency between reminderScheduler and credit-service#25312
Conversation
…ervice - Created WorkflowReminderRepository to handle workflow reminder queries - Refactored cancelScheduledMessagesAndScheduleEmails to accept userIdsWithoutCredits parameter - Moved credit-checking logic from workflows to CreditService - Changed dynamic import to static import in CreditService - Updated tests to pass userIdsWithoutCredits parameter - Removed unused imports (prisma, WorkflowMethods) This creates a one-way dependency (billing -> workflows) and follows the repository pattern by removing direct Prisma usage from reminderScheduler. Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/features/ee/billing/credit-service.ts">
<violation number="1" location="packages/features/ee/billing/credit-service.ts:608">
Team-level credit exhaustion no longer cancels SMS reminders because the membership lookup passes the teamId to a userId-based query and the returned rows lack userId entirely, so the list of out-of-credit members is always empty.</violation>
<violation number="2" location="packages/features/ee/billing/credit-service.ts:634">
Rule violated: **Avoid Logging Sensitive Information**
Do not log the full `result` object because `LowCreditBalanceResult` holds user and admin names/emails; log only non-PII identifiers instead.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
- Use MembershipRepository.listAcceptedTeamMemberIds instead of findAllAcceptedPublishedTeamMemberships - Re-add prisma import to reminderScheduler.ts for UserRepository - Update WorkflowReminderRepository to use WorkflowActions enum instead of string Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
E2E results are ready! |
10 tasks
ThyMinimalDev
approved these changes
Nov 24, 2025
3 tasks
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
packages/features/ee/workflows/lib/reminders/reminderScheduler.tsandpackages/features/ee/billing/credit-service.tsWorkflowReminderRepositoryfor prisma queries and madecancelScheduledMessagesAndScheduleEmailsaccept pre-computeduserIdsWithNoCreditsparameterMandatory Tasks (DO NOT REMOVE)
How should this be tested?