feat: enhance CreatedAuditActionService with Salesforce app data for Team Round Robin events#26012
Closed
hariombalhara wants to merge 1 commit intobooking-audit-more-infrafrom
Closed
Conversation
…Team Round Robin events - Add Salesforce audit data schema to track lead/contact creation, event record fields, and lead/contact fields - Create extractSalesforceAuditData helper function to extract Salesforce data from EventManager results - Update Salesforce CRM service to capture and return audit data (eventRecordFields, leadOrContactFields) - Update RegularBookingService to pass Salesforce data to audit system - Export SalesforceAuditData and AppsAuditData types for external use Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcfe88d to
e4ef443
Compare
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhances the booking audit system to capture Salesforce CRM data during booking creation, specifically for Team Round Robin events. This builds on PR #25125 (booking-audit-more-infra).
Changes:
CreatedAuditActionServiceto track lead/contact creation and field writesextractSalesforceAuditDatahelper to extract Salesforce data from EventManager resultsRegularBookingServiceto pass extracted Salesforce data to the audit systemData captured:
Link to Devin run: https://app.devin.ai/sessions/2b352c202412416d95ac10c6202178d2
Requested by: hariom@cal.com (@hariombalhara)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
apps.salesforce.leadOrContactCreatedshould contain the contact/lead ID and typeapps.salesforce.eventRecordFieldsshould contain fields written to the SF Eventapps.salesforce.leadOrContactFieldsshould contain fields written to the lead/contactEnvironment variables needed:
Checklist
Items for Human Review
writeToRecordAndReturnFieldscorrectly mirrorswriteToRecordbehavior (CrmService.ts lines 1099-1168)salesforceCreateEventexist that might be affected by the return type changecreatedRecordshould be populated when new leads/contacts are created (currently only captures existing contacts)extractSalesforceAuditDatahelper function are not included