feat(salesforce): exclude Salesforce-assigned bookings from Round Robin calculations

[JagjeevanAK]

Summary

Add an option in Salesforce app settings to exclude bookings assigned via Salesforce owner lookup from Round Robin fairness calculations. When enabled, only bookings assigned through Round Robin logic will count towards host booking counts.

Fixes #18216

Changes

• Add excludeSalesforceBookingsFromRR setting to Salesforce app schema
• Add UI toggle in EventType > Apps > Salesforce settings (only visible for Round Robin event types)
• Modify BookingRepository.getAllBookingsForRoundRobin to filter out SALESFORCE_ASSIGNMENT bookings
• Update getLuckyUser service to accept and pass the exclusion flag
• Update all callers to extract and pass the flag from eventType metadata
• Add i18n translation strings for the new toggle

Related PRs

This is a reopening of #21861 which was closed due to inactivity. The approach was changed based on reviewer feedback from @CarinaWolli - the setting is now stored in Salesforce app metadata (EventType > Apps tab) rather than as a separate EventType database field.

How it works

1. When the toggle is enabled in Salesforce app settings for a Round Robin event type
2. The booking repository filters out any bookings that have AssignmentReasonEnum.SALESFORCE_ASSIGNMENT as their assignment reason
3. This means bookings where the host was assigned because they own the Salesforce contact/lead don't count towards the Round Robin booking counts
4. Only bookings assigned through the normal Round Robin algorithm are counted for fairness calculations

Testing

• Manual testing of the UI toggle
• Verify bookings with Salesforce assignment reason are excluded when flag is enabled
• Verify normal Round Robin behavior when flag is disabled

[vercel]

@JagjeevanAK is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

[JagjeevanAK]

Hey @dhairyashiil this PR is ready from my side

[cubic-dev-ai]

No issues found across 11 files

[dhairyashiil]

Could you please attach video showing the before and after of your changes? In the meantime, I'll mark this as a draft

[JagjeevanAK]

Hey It eas already partially approved if you can see PR referenced to it will add video to it

[cubic-dev-ai]

1 issue found across 11 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/app-store/salesforce/components/EventTypeAppCardInterface.tsx">

<violation number="1" location="packages/app-store/salesforce/components/EventTypeAppCardInterface.tsx:494">
P2: Use `htmlFor` instead of `for` to maintain proper label-input association in React.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[JagjeevanAK]

Hey @dhairyashiil I dont have salseforce account for this can you just check the liked PR in description ?

[github-actions]

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

[github-actions]

Devin AI is resolving merge conflicts

This PR has merge conflicts with the main branch. A Devin session has been created to automatically resolve them.

View Devin Session

Devin will:

1. Merge the latest main into this branch
2. Resolve any conflicts intelligently
3. Run lint/type checks to ensure validity
4. Push the resolved changes

If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself.

[github-actions]

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

[JagjeevanAK]

hey @keithwillcode any change to get consumer_key & consumer_secret of salseforce CRM for testing ?