Skip to content

fix: Add uuid to mock session objects in organization validation tests#26455

Merged
hariombalhara merged 1 commit intodevin/add-uuid-1765964723from
devin/fix-uuid-typecheck-1767611084
Jan 5, 2026
Merged

fix: Add uuid to mock session objects in organization validation tests#26455
hariombalhara merged 1 commit intodevin/add-uuid-1765964723from
devin/fix-uuid-typecheck-1767611084

Conversation

@hariombalhara
Copy link
Member

What does this PR do?

Fixes TypeScript type errors in organization validation test files caused by the parent PR #25963 which added uuid as a required field on Session.user.

After a recent merge brought in new test files (validateUserHasOrg.test.ts and validateUserHasOrgAdmin.test.ts), the mock session objects in these files were missing the required uuid property, causing 12 type errors during CI typecheck.

This PR adds uuid: "test-uuid-123" to all mock session user objects in both test files.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - test file changes only.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run yarn type-check:ci --force and verify no type errors related to validateUserHasOrg.test.ts or validateUserHasOrgAdmin.test.ts
  2. The CI typecheck job should pass after this fix

Human Review Checklist

  • Verify uuid is added to all 12 mock session objects that were causing type errors (4 in validateUserHasOrg.test.ts, 8 in validateUserHasOrgAdmin.test.ts)
  • Confirm the hardcoded test UUID value "test-uuid-123" is appropriate for test purposes (no test logic depends on unique UUIDs)

Link to Devin run: https://app.devin.ai/sessions/b0276d8c67b14ebc8588f6c1ef40594e
Requested by: hariom@cal.com (@hariombalhara)

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@hariombalhara hariombalhara marked this pull request as ready for review January 5, 2026 11:38
@hariombalhara hariombalhara merged commit f7abd19 into devin/add-uuid-1765964723 Jan 5, 2026
14 checks passed
@hariombalhara hariombalhara deleted the devin/fix-uuid-typecheck-1767611084 branch January 5, 2026 11:38
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant