fix: workflow locale

[Udit-takkar]

What does this PR do?

This PR fixes the issue when workflow reminder body isn't translated to attendee's locale.

Updates since last revision

Latest (hariombalhara's feedback): Extracted the template matching logic into a separate testable function with comprehensive unit tests.

Changes:

• Created detectMatchedTemplate function in packages/features/ee/workflows/lib/detectMatchedTemplate.ts
• Added 20 unit tests covering all edge cases (empty body, body/subject matching, HTML stripping, null defaults, etc.)
• Refactored EmailWorkflowService to use the new function

Previous (CarinaWolli's feedback): Now checks both email body AND subject against default templates before regenerating with recipient's locale. Previously only the body was checked, which meant a customized subject would be overwritten with the default when the body matched the template.

Changes:

• Added getTemplateSubjectForAction helper function to get default subject for templates
• Updated template matching logic to require both body AND subject to match defaults
• If either is customized, falls through to customTemplate() path to preserve user edits

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

1. Create a workflow with EMAIL_ATTENDEE action using REMINDER template
2. Customize only the subject (keep default body) and save
3. Trigger the workflow - verify the custom subject is preserved (not overwritten with default)
4. Test with default subject + default body - verify translation works for attendee's locale

Human Review Checklist

• Verify detectMatchedTemplate function behavior matches the original inline logic
• Verify subject comparison uses strict equality while body uses HTML-stripped comparison (intentional since subjects don't contain HTML)
• Check edge case: when emailBody is empty but template is specified, subject customization is not checked (matches original behavior)
• Review the 20 unit tests in detectMatchedTemplate.test.ts for completeness

---

Link to Devin run: https://app.devin.ai/sessions/fd81f5a877f447aaa8112dd55148953d
Requested by: udit@cal.com (@Udit-takkar)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
api-v2	Ignored	Preview	Jan 8, 2026 9:05am
cal	Ignored		Jan 8, 2026 9:05am
cal-companion	Ignored	Preview	Jan 8, 2026 9:05am
cal-eu	Ignored		Jan 8, 2026 9:05am

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/ee/workflows/lib/service/EmailWorkflowService.ts">

<violation number="1" location="packages/features/ee/workflows/lib/service/EmailWorkflowService.ts:418">
P1: Potential regression when `reminderBody` is null but `template` is REMINDER/RATING. The old code would generate the default template from the `template` parameter, but the new code only generates templates when `matchedTemplate` is set (which requires `emailBody` to be truthy). Consider adding a fallback to check the `template` parameter when `emailBody` is empty:

```javascript
} else if (emailBody) {
  // custom processing
} else if (template === WorkflowTemplates.REMINDER) {
  // Generate REMINDER with correct locale (fallback for empty body)
} else if (template === WorkflowTemplates.RATING) {
  // Generate RATING with correct locale (fallback for empty body)
}
```</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[CarinaWolli]

We are only checking for changes in the email body and not the subject. So if only the subject was changed for the reminder template, then we are doing the translation using the default reminder subject instead of sending the custom email subject

[cubic-dev-ai]

No issues found across 3 files

[github-actions]

E2E results are ready!

• Workflow #98532.2 latest results

pls re review

[hariombalhara]

There is a scope of code quality improvement and I think tests are also required

[cubic-dev-ai]

No issues found across 5 files

re review

[hariombalhara]

LGTM !!