-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: allow link cloaking for Organization accounts in workflow emails #26528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9658d12
feat: allow link cloaking for Organization accounts in workflow emails
devin-ai-integration[bot] f56de45
Merge branch 'main' into devin/org-link-cloaking-1767773716
PeerRich 16c2cef
Merge branch 'main' into devin/org-link-cloaking-1767773716
PeerRich a8cd91b
Merge branch 'main' into devin/org-link-cloaking-1767773716
devin-ai-integration[bot] 4941fd5
chore: optimise query
sean-brydon 994576d
Merge branch 'main' into devin/org-link-cloaking-1767773716
sean-brydon a1023d5
fix types
sean-brydon f76cfb2
Merge remote-tracking branch 'refs/remotes/origin/devin/org-link-cloa…
sean-brydon f0995bd
chore: make sure workflow reminders and email remainders take in cloa…
Ryukemeister a988a12
Merge branch 'main' into devin/org-link-cloaking-1767773716
Ryukemeister 5759a40
Merge branch 'main' into devin/org-link-cloaking-1767773716
sean-brydon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This change contradicts the stated security design in the PR description. The description explicitly says this deprecated file should "default to sanitizing all links (safer behavior)" as the intentional security posture for edge cases. Adding the organization check here allows cloaked links for organizations, which is inconsistent with that design. If the stricter default is intended for deprecated paths, remove these organization checks and let all emails have links sanitized in this file.
Prompt for AI agents
Fix confidence (alpha): 8/10