Skip to content

Comments

fix: lowercase identifier values in routing form editor#26616

Merged
PeerRich merged 10 commits intomainfrom
devin/lowercase-routing-form-identifier-1767961253
Jan 27, 2026
Merged

fix: lowercase identifier values in routing form editor#26616
PeerRich merged 10 commits intomainfrom
devin/lowercase-routing-form-identifier-1767961253

Conversation

@PeerRich
Copy link
Member

@PeerRich PeerRich commented Jan 9, 2026

What does this PR do?

Lowercases the "Identifier (URL Parameter)" field values in the routing form editor (/routing/form-edit/). This ensures URL parameters are consistently lowercase.

Changes:

  • Auto-generated identifiers from labels are now lowercased
  • Manual user input in the identifier field is automatically converted to lowercase
  • Removed unused @ts-expect-error directives (cleanup)
  • Updated E2E tests to use lowercase identifiers to match new behavior

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Go to /apps/routing-forms/forms
  2. Create a new routing form or edit an existing one
  3. Add a new field with a label containing uppercase letters (e.g., "What Is Your Name")
  4. Verify the auto-generated identifier is lowercase (e.g., "what-is-your-name")
  5. Try manually typing uppercase letters in the identifier field
  6. Verify the input is automatically converted to lowercase

Human Review Checklist

  • Verify this is the desired behavior for URL parameters
  • Consider if existing forms with uppercase identifiers need any migration or if this only affects new/edited fields
  • The comparison logic for detecting auto-generated identifiers now compares against lowercase - verify this doesn't cause issues with existing forms

Requested by: @PeerRich
Link to Devin run: https://app.devin.ai/sessions/a520835270b14c94bc5b67abe3255ad7

Co-Authored-By: peer@cal.com <peer@cal.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
api-v2 Ignored Ignored Preview Jan 11, 2026 11:02am
cal Ignored Ignored Jan 11, 2026 11:02am
cal-companion Ignored Ignored Preview Jan 11, 2026 11:02am
cal-eu Ignored Ignored Jan 11, 2026 11:02am

Co-Authored-By: peer@cal.com <peer@cal.com>
@keithwillcode keithwillcode added the core area: core, team members only label Jan 10, 2026
@github-actions
Copy link
Contributor

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 19, 2026
@PeerRich PeerRich marked this pull request as ready for review January 22, 2026 16:05
@github-actions
Copy link
Contributor

Devin AI is resolving merge conflicts

This PR has merge conflicts with the main branch. A Devin session has been created to automatically resolve them.

View Devin Session

Devin will:

  1. Merge the latest main into this branch
  2. Resolve any conflicts intelligently
  3. Run lint/type checks to ensure validity
  4. Push the resolved changes

If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@PeerRich PeerRich enabled auto-merge (squash) January 23, 2026 14:08
hariombalhara
hariombalhara previously approved these changes Jan 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

E2E results are ready!

@PeerRich PeerRich merged commit 9b1f86a into main Jan 27, 2026
48 checks passed
@PeerRich PeerRich deleted the devin/lowercase-routing-form-identifier-1767961253 branch January 27, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ready-for-e2e size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants