fix(phone-input): add Austria mask and prevent double plus prefix #26626
Merged
anikdhabal merged 4 commits intocalcom:mainfrom Jan 13, 2026
Merged
fix(phone-input): add Austria mask and prevent double plus prefix #26626anikdhabal merged 4 commits intocalcom:mainfrom
anikdhabal merged 4 commits intocalcom:mainfrom
Conversation
|
@abhayymishraa is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/components/phone-input/PhoneInput.tsx">
<violation number="1" location="packages/features/components/phone-input/PhoneInput.tsx:84">
P1: The double plus prevention fix is incomplete. `BasePhoneInputWeb` (line 128) still uses the old pattern `onChange(\`+${val}\`)` and will produce `++` when users paste numbers with the prefix. Consider applying the same fix to maintain consistency.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Author
|
@pallava-joshi @dhairyashiil could you take a look into it? |
Contributor
|
@@cubic-dev-ai can you pls review the changes again? |
Contributor
@anikdhabal I have started the AI code review. It will take a few minutes to complete. |
anikdhabal
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the PhoneInput component by addressing inconsistent phone number formatting and user experience issues:
+43 123 456789to a cleaner+43 XXX XXX XXXXformatonChangehandler to check if the value already starts with+before prepending it, preventing issues like++1234567890when users paste numbers that already include the prefixVisual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Fixed the issue:
Screen.Recording.2026-01-09.at.10.12.59.PM.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Test the Austria Mask:
yarn dev6601234567660 123 4567Test the Double Plus Prevention:
+436601234567++436601234567Checklist