Skip to content

feat(companion): manifest id for safari extension & add delete account link #26802

Merged
dhairyashiil merged 2 commits intomainfrom
feat/manifest-id-for-safari
Jan 13, 2026
Merged

feat(companion): manifest id for safari extension & add delete account link #26802
dhairyashiil merged 2 commits intomainfrom
feat/manifest-id-for-safari

Conversation

@dhairyashiil
Copy link
Member

@dhairyashiil dhairyashiil commented Jan 13, 2026

Screen.Recording.2026-01-13.at.8.36.43.PM.mov

Summary by cubic

Safari builds now use "Cal.com" as the extension name to match platform requirements; the More tab now includes a Delete Account link. Other browsers keep "Cal.com Companion".

Written for commit b6c15c0. Summary will update on new commits.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 13, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@dhairyashiil dhairyashiil changed the title feat(companion): manifest id for safari extension feat(companion): manifest id for safari extension & add delete account link Jan 13, 2026
{/* Sign Out Button */}
{/* Delete Account Link */}
<View className="mt-6 overflow-hidden rounded-lg border border-[#E5E5EA] bg-white">
<TouchableOpacity
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ios app

{/* Sign Out Button */}
{/* Delete Account Link */}
<View className="mt-6 overflow-hidden rounded-lg border border-[#E5E5EA] bg-white">
<TouchableOpacity
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for android and extension

outDir: ".output",
manifest: {
name: "Cal.com Companion",
name: browserTarget === "safari" ? "Cal.com" : "Cal.com Companion",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this to match apple's platform requirements

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(more)/index.ios.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.ios.tsx:151">
P2: User-facing text "Delete Account" is hard-coded instead of using the required `t()` localization helper, so the new button cannot be translated.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link
Contributor

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

@dhairyashiil dhairyashiil enabled auto-merge (squash) January 13, 2026 15:22
@dhairyashiil dhairyashiil merged commit 69695d3 into main Jan 13, 2026
52 checks passed
@dhairyashiil dhairyashiil deleted the feat/manifest-id-for-safari branch January 13, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments