fix: Duplicate calls syncing Calendar integrations#26858
Merged
Conversation
emrysal
commented
Jan 15, 2026
| }; | ||
| } | ||
|
|
||
| static getSelectedCalendarsFromUser<TSelectedCalendar extends { eventTypeId: number | null }>({ |
Contributor
Author
There was a problem hiding this comment.
Not related to the issue being fixed, but a big anti-pattern and risk-free.
Contributor
E2E results are ready! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
pedroccastro
approved these changes
Jan 15, 2026
Contributor
pedroccastro
left a comment
pedroccastro
left a comment
There was a problem hiding this comment.
Good optimization! 👍
emrysal
deleted the
bugfix/remove-duplicate-calls-to-connectedCalendars
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes duplicate calendar sync calls by scoping and reusing data in calendar settings. Reduces unnecessary API requests and speeds up onboarding and settings pages.
Written for commit 94a67e2. Summary will update on new commits.