Skip to content

fix: seated event bug#26929

Merged
anikdhabal merged 7 commits intomainfrom
fix/seated-event-2
Jan 16, 2026
Merged

fix: seated event bug#26929
anikdhabal merged 7 commits intomainfrom
fix/seated-event-2

Conversation

@Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jan 16, 2026

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Fixes attendee visibility in reassignment emails for seated events. Reassignment notifications now show or hide the attendee list based on the event’s seatsShowAttendees setting.

  • Bug Fixes
    • Pass showAttendees to AttendeeUpdatedEmail via sendReassignedUpdatedEmailsAndSMS; include seatsPerTimeSlot in the reassignment payload to flag seated events.
    • Set showAttendees from the event type during reassignment across round-robin and managed-event flows.

Written for commit 416cd24. Summary will update on new commits.

@anikdhabal anikdhabal marked this pull request as ready for review January 16, 2026 11:36
@graphite-app graphite-app bot added enterprise area: enterprise, audit log, organisation, SAML, SSO core area: core, team members only labels Jan 16, 2026
@graphite-app graphite-app bot requested a review from a team January 16, 2026 11:36
@anikdhabal anikdhabal enabled auto-merge (squash) January 16, 2026 11:36
anikdhabal
anikdhabal previously approved these changes Jan 16, 2026
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

anikdhabal
anikdhabal previously approved these changes Jan 16, 2026
...(platformClientParams ? platformClientParams : {}),
conferenceCredentialId: conferenceCredentialId ?? undefined,
organizationId: orgId,
seatsPerTimeSlot: eventType.seatsPerTimeSlot,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to add this change as well here? is this fixing something else too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, found the reason, it is being used down the flow and without it seatsShowAttendees false wont actually jhave an effect

Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Member

@Udit-takkar @anikdhabal Devin says this. Looks like a bug

In ManagedEventManualReassignmentService.ts:700-705, the withEventType call does NOT include seatsPerTimeSlot:
.withEventType({
id: targetEventTypeDetails.id,
slug: targetEventTypeDetails.slug,
description: newBooking.description,
schedulingType: parentEventType.schedulingType,
})
The filtering logic in AttendeeScheduledEmail requires BOTH conditions:
if (!showAttendees && calEvent.seatsPerTimeSlot) { ... }
Impact: The fix adds showAttendees: !!targetEventTypeDetails.seatsShowAttendees but without seatsPerTimeSlot on the calEvent, the filtering won't execute. The fix works for round-robin reassignments but may not work for managed event reassignments.

Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking till, we get confirmation on possible bug higlighted by Devin

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

E2E results are ready!

@github-actions github-actions bot marked this pull request as draft January 16, 2026 11:57
auto-merge was automatically disabled January 16, 2026 11:57

Pull request was converted to draft

@anikdhabal anikdhabal marked this pull request as ready for review January 16, 2026 12:21
@anikdhabal anikdhabal enabled auto-merge (squash) January 16, 2026 12:21
@anikdhabal
Copy link
Contributor

anikdhabal commented Jan 16, 2026

@hariombalhara good find, missed it

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments