Conversation
| ...(platformClientParams ? platformClientParams : {}), | ||
| conferenceCredentialId: conferenceCredentialId ?? undefined, | ||
| organizationId: orgId, | ||
| seatsPerTimeSlot: eventType.seatsPerTimeSlot, |
There was a problem hiding this comment.
What is the reason to add this change as well here? is this fixing something else too?
There was a problem hiding this comment.
nvm, found the reason, it is being used down the flow and without it seatsShowAttendees false wont actually jhave an effect
|
@Udit-takkar @anikdhabal Devin says this. Looks like a bug In ManagedEventManualReassignmentService.ts:700-705, the withEventType call does NOT include seatsPerTimeSlot: |
hariombalhara
left a comment
There was a problem hiding this comment.
Blocking till, we get confirmation on possible bug higlighted by Devin
E2E results are ready! |
Pull request was converted to draft
|
@hariombalhara good find, missed it |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Fixes attendee visibility in reassignment emails for seated events. Reassignment notifications now show or hide the attendee list based on the event’s seatsShowAttendees setting.
Written for commit 416cd24. Summary will update on new commits.