feat: allow email invites in team event-type assignment#26957
feat: allow email invites in team event-type assignment#26957yuvrajangadsingh wants to merge 2 commits intocalcom:mainfrom
Conversation
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx">
<violation number="1" location="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx:231">
P2: Email invite hosts all use userId=0, but updatedHosts matches only on userId, causing later email invites to reuse the first invite’s groupId/scheduleId</violation>
</file>
<file name="apps/web/modules/event-types/components/CheckedTeamSelect.tsx">
<violation number="1" location="apps/web/modules/event-types/components/CheckedTeamSelect.tsx:109">
P2: Duplicate emails in a single comma-separated input aren’t deduped, allowing identical invite entries to be added in one create action.</violation>
<violation number="2" location="apps/web/modules/event-types/components/CheckedTeamSelect.tsx:148">
P1: React-select props from callers (e.g., isOptionDisabled, controlShouldRenderValue) are no longer forwarded, causing regressions like allowing disabled options to be selected.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx
Show resolved
Hide resolved
|
@cubic-dev-ai please re-review |
@yuvrajangadsingh I have started the AI code review. It will take a few minutes to complete. |
975d355 to
c4c4929
Compare
|
Hi, I’m interested in helping. Is there any remaining work or follow-up tasks needed for this feature? |
|
Thanks for the interest @omwanere! The feature implementation is complete and the PR is ready for maintainer review. No additional work needed at the moment - just waiting on the team to review and merge. 🙏 |
ef9b85e to
84ee510
Compare
|
Hey @anikdhabal @keithwillcode - this PR is also ready for review. It allows email invites in team event-type assignment (addresses issue #13532). Rebased on latest main. Thanks! 🙏 |
5a7588c to
cf982e2
Compare
|
Hey, friendly bump on this one — it's been a few weeks. All review feedback is addressed and CI is passing. Would love a maintainer review when someone gets a chance! |
ede602c to
d921ec9
Compare
c57d528 to
0c38178
Compare
|
just rebased on latest main, everything is clean. would appreciate a review when someone has bandwidth — this has been ready for a while now. |
8429529 to
ca01133
Compare
- Update CheckedTeamSelect to use CreatableSelect for email input - Add email validation and comma-separated email parsing - Add isEmailInvite and email fields to Host and CheckedSelectOption types - Pass allowEmailInvites prop through AddMembersWithSwitch - Enable email invites in EventTeamAssignmentTab for both fixed and round-robin hosts Closes calcom#13532
- Forward caller props to CreatableSelect (isOptionDisabled, etc.) - Dedupe emails in comma-separated input - Fix userId=0 collision by matching email invites by email
ca01133 to
4d387e8
Compare
Summary
Changes
CheckedTeamSelectto useCreatableSelectfor email inputisEmailInviteandemailfields toHostandCheckedSelectOptiontypesallowEmailInvitesprop throughAddMembersWithSwitchcomponent chainEventTeamAssignmentTabfor both fixed and round-robin hostsTest plan
Closes #13532
/claim #13532