fix: enable alby app in E2E tests to fix payment-apps test failures#27071
Merged
fix: enable alby app in E2E tests to fix payment-apps test failures#27071
Conversation
PR #27012 introduced logic to disable apps without valid keys during seeding. This caused the alby payment app tests to fail because the alby app was disabled in the App table when its environment keys weren't configured. This fix adds an ensureAppEnabled helper function that enables the app in the App table before running the tests, treating it as a mock/test setup step. Co-Authored-By: alex@cal.com <me@alexvanandel.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/playwright/payment-apps.e2e.ts">
<violation number="1" location="apps/web/playwright/payment-apps.e2e.ts:21">
P1: Rule violated: **E2E Tests Best Practices**
This helper flips a seeded App record to enabled without any cleanup, leaving the DB in a different state after the test. E2E tests must reset the DB state to what it was before to avoid side-effects across parallel runs (E2E Tests Best Practices: reset DB state / avoid side-effects).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. ✅ Pushed commit |
Address Cubic AI review feedback: the ensureAppEnabled helper now returns a cleanup function that restores the app's original enabled state after the test completes. This prevents side-effects across parallel test runs. Co-Authored-By: alex@cal.com <me@alexvanandel.com>
anikdhabal
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes consistently failing E2E tests in
payment-apps.e2e.tscaused by PR #27012.PR #27012 introduced logic to disable apps without valid keys during database seeding. This caused the alby payment app tests to fail because the alby app was disabled in the App table when its environment keys weren't configured in CI.
This fix adds an
ensureAppEnabledhelper function that enables the app in the App table before running the tests, treating it as a mock/test setup step.Failing tests fixed:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Human Review Checklist
noExcessiveLinesPerFunctionwarning is acceptableChecklist
Link to Devin run: https://app.devin.ai/sessions/070e00078cc049c2ad8f59a5ef82c5da
Requested by: @emrysal