Conversation
…m packages/features to apps/web/modules Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…and update imports Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…dars-schedules-to-web' into devin/1769362470-move-auth-calendars-schedules-to-web Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…dars-schedules-to-web' into devin/1769362470-move-auth-calendars-schedules-to-web
Contributor
E2E results are ready! |
…-auth-calendars-schedules-to-web
hbjORbj
commented
Jan 28, 2026
| @@ -187,23 +187,6 @@ const CopyButton = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| const Schedule = < | |||
Contributor
Author
There was a problem hiding this comment.
Moved to apps/web/modules/schedules/components/Schedule.tsx
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…-auth-calendars-schedules-to-web
ThyMinimalDev
previously approved these changes
Jan 29, 2026
Contributor
ThyMinimalDev
left a comment
ThyMinimalDev
left a comment
There was a problem hiding this comment.
awesome, nice types to replace trpc router outputs infered types
Contributor
|
DevinAI can you fix type checks issues, it's mostly duplicate identifier errors |
…or import path Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Contributor
|
Fixed the duplicate identifier errors. The issue was in
All CI checks are now passing. |
ThyMinimalDev
approved these changes
Jan 29, 2026
hbjORbj
deleted the
devin/1769362470-move-auth-calendars-schedules-to-web
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a PR extracting simple migrations from #26571 (which is too large to review at 244 files).
Moves tRPC-dependent UI components from
packages/featurestoapps/web/modulesto eliminate circular dependencies:Feature flags:
FlagAdminList.tsx,AssignFeatureSheet.tsx→apps/web/modules/feature-flags/components/hooks/index.ts→apps/web/modules/feature-flags/hooks/flag-listing-view.tsx→apps/web/modules/feature-flags/views/Calendars:
AdditionalCalendarSelector.tsx,NoAvailabilityDialog.tsx→apps/web/modules/calendars/components/DatePicker.tsx→apps/web/modules/calendars/DatePicker.tsxDestinationCalendarSelector.tsx→packages/features/calendars/components/(reorganized within packages/features)Schedules:
Schedule.tsx,NewScheduleButton.tsx→apps/web/modules/schedules/components/date-override-list.test.tsxmoved with componentType refactoring (to remove tRPC RouterOutputs dependency):
DateOverrideList.tsx- replacedRouterOutputs["viewer"]["travelSchedules"]["get"]with localTravelScheduleinterfaceScheduleListItem.tsx- replacedRouterOutputs["viewer"]["availability"]["list"]["schedules"][number]with localScheduleinterfaceDestinationCalendarSelector.tsx- replacedRouterOutputs["viewer"]["calendars"]["connectedCalendars"]with local interfaces