Skip to content

Comments

chore: use gh auth login with token for commit step in draft-release job#27248

Merged
ThyMinimalDev merged 1 commit intomainfrom
fix-draft-release-commit-step-token-2
Jan 26, 2026
Merged

chore: use gh auth login with token for commit step in draft-release job#27248
ThyMinimalDev merged 1 commit intomainfrom
fix-draft-release-commit-step-token-2

Conversation

@ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Jan 26, 2026

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
  • My PR is too large (>500 lines or >10 files) and should be split into smaller PRs

Summary by cubic

Authenticate the draft-release job’s commit step by logging into gh with the generated GITHUB_TOKEN, ensuring commits are properly authorized and succeed in CI.

Written for commit 0d3c867. Summary will update on new commits.

@ThyMinimalDev ThyMinimalDev requested a review from a team as a code owner January 26, 2026 14:22
@graphite-app graphite-app bot added core area: core, team members only foundation labels Jan 26, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

VERSION: ${{ inputs.next_version }}
GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
run: |
echo "$GITHUB_TOKEN" | gh auth login --with-token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThyMinimalDev Do we need to pipe the echo like this? Can we instead send the token straight in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like gh auth login --with-token expects the token on standard input

@ThyMinimalDev ThyMinimalDev merged commit 8848efe into main Jan 26, 2026
90 of 93 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-draft-release-commit-step-token-2 branch January 26, 2026 14:38
@Arc-a-it

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants