fix: hide cancel/reschedule links in emails when disabled#27637
Merged
anikdhabal merged 1 commit intocalcom:mainfrom Feb 10, 2026
Merged
Conversation
When disableCancelling or disableRescheduling is enabled on an event type, the confirmation email still showed non-functional cancel/reschedule links. The ManageLink email component already had correct conditional logic to hide these links, but two flows constructed the CalendarEvent manually without including the flags: the booking confirmation handler and the payment booking flow. This caused the flags to be undefined, which ManageLink interpreted as enabled. Added disableCancelling and disableRescheduling to the Prisma select and CalendarEvent object in both confirm.handler.ts and getBooking.ts. Closes calcom#22906
|
Paragon Review Unavailable Hi @evertonresende! To enable Paragon reviews on this repository, please register at https://home.polarity.cc Once registered, connect your GitHub account and Paragon will automatically review your pull requests. |
volnei
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22906
When
disableCancellingordisableReschedulingis enabled on an event type, confirmation emails still showed non-functional cancel/reschedule links. This was confusing for attendees who clicked links that led to error pages.Root cause: The
ManageLinkemail component already had correct conditional logic to hide these links based oncalEvent.disableCancellingandcalEvent.disableRescheduling. However, two code paths constructed theCalendarEventobject manually without including these flags:confirm.handler.ts) — used when organizers confirm pending bookingsgetBooking.ts) — used when bookings involve paymentsSince the flags were
undefined,!undefined === true, soManageLinkalways rendered the links.Changes
disableCancellinganddisableReschedulingto the PrismaselectforeventTypein both filesCalendarEventobject with?? falsefallbackTest plan