Conversation
…b modules Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
…ble-hooks-to-web Co-Authored-By: unknown <>
|
Merge conflicts with
Note: Unable to remove the |
E2E results are ready! |
The data-table hooks (useDataTable, useFilterValue) were moved from @calcom/features/data-table to ~/data-table/hooks/ in #27833 but this file was missed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Another import missed in #27833 refactor — DataTableProvider moved from @calcom/features/data-table/ to ~/data-table/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: update data-table hook imports after refactor (#27833) The data-table hooks (useDataTable, useFilterValue) were moved from @calcom/features/data-table to ~/data-table/hooks/ in #27833 but this file was missed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update DataTableProvider import path in insights-wrong-routing-view Another import missed in #27833 refactor — DataTableProvider moved from @calcom/features/data-table/ to ~/data-table/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
What does this PR do?
Moves client-side data-table code (React hooks, contexts,
DataTableProvider) frompackages/features/data-table/toapps/web/modules/data-table/, per the vertical slice architecture rule thatpackages/featuresshould only contain framework-agnostic code.Recreates the work from the closed #27228, rebased on top of the recent data-table refactors.
Moved to
apps/web/modules/data-table/:hooks/(12 files) — all React hooks (useDataTable,useColumnFilters,useFilterValue, etc.)contexts/(4 files) —DataTableFiltersContext,DataTableSegmentContext,DataTableStateContextDataTableProvider.tsxStays in
packages/features/data-table/:lib/— types, utils, serializers, parsers, dateRangerepositories/— filterSegment data access__tests__/,GUIDE.mdindex.ts— trimmed to only re-exportlib/types,lib/utils,lib/serializers,lib/separatorImport updates (~40 consumer files):
ColumnFilterType,ZFilterValue,convertFacetedValuesToMap, etc.) continue importing from@calcom/features/data-table~/data-table/...pathsGUIDE.md updates:
@calcom/features/data-table(types/utils) and~/data-table/...(hooks/provider/components)packages/features/locationsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn type-check:ci --force— should pass (pre-existing embed-react errors are unrelated)yarn lint— should pass with only pre-existing warningsChecklist
Human Review Checklist
ActiveFiltersValidatortype import inuseActiveFiltersValidator.ts— it now imports from~/data-table/DataTableProviderinstead of the barrel@calcom/features/data-table, since this type was defined in the contexts that movedpackages/were missed that import hooks/contexts from the old barrel export (CI type-check passed, but worth a quick scan)Link to Devin run: https://app.devin.ai/sessions/8fe2052a192d4b44ace0377b0b97d772
Requested by: @eunjae-lee