feat: allow team members to be optional guests#27986
Closed
aiko-service wants to merge 1 commit intocalcom:mainfrom
Closed
feat: allow team members to be optional guests#27986aiko-service wants to merge 1 commit intocalcom:mainfrom
aiko-service wants to merge 1 commit intocalcom:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/public/static/locales/en/common.json">
<violation number="1" location="apps/web/public/static/locales/en/common.json:4636">
P3: Duplicate localization keys "optional" and "required" are added even though they already exist earlier in common.json, creating duplicate JSON keys and overriding earlier values. Please reuse the existing keys instead of redefining them here.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "calendar_events_disabled_video_limitation": "When calendar events are disabled, meeting links cannot be generated for apps whose link generation is tied to calendar event creation, for example, Google Meet and Microsoft Teams. Other video apps like Cal Video will continue to work.", | ||
| "make_optional": "Make optional", | ||
| "make_required": "Make required", | ||
| "optional": "Optional", |
Contributor
There was a problem hiding this comment.
P3: Duplicate localization keys "optional" and "required" are added even though they already exist earlier in common.json, creating duplicate JSON keys and overriding earlier values. Please reuse the existing keys instead of redefining them here.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/public/static/locales/en/common.json, line 4636:
<comment>Duplicate localization keys "optional" and "required" are added even though they already exist earlier in common.json, creating duplicate JSON keys and overriding earlier values. Please reuse the existing keys instead of redefining them here.</comment>
<file context>
@@ -4631,5 +4631,9 @@
"calendar_events_disabled_video_limitation": "When calendar events are disabled, meeting links cannot be generated for apps whose link generation is tied to calendar event creation, for example, Google Meet and Microsoft Teams. Other video apps like Cal Video will continue to work.",
+ "make_optional": "Make optional",
+ "make_required": "Make required",
+ "optional": "Optional",
+ "required": "Required",
"ADD_NEW_STRINGS_ABOVE_THIS_LINE_TO_PREVENT_MERGE_CONFLICTS": "↑↑↑↑↑↑↑↑↑↑↑↑↑ Add your new strings above here ↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑"
</file context>
Author
|
Closing in favor of updated PR with conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to mark team members as optional hosts. Optional hosts are invited to the meeting but their availability does not block the meeting from being booked.
Key changes:
isOptionalfield toHostmodel.getAggregatedAvailabilityto ignore optional hosts when calculating team availability.Fixes #18947