Fixes slack verification and timeout errors#2972
Merged
sean-brydon merged 18 commits intomainfrom Jun 11, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-brydon
commented
Jun 6, 2022
| } | ||
|
|
||
| if (req.method === "GET") { | ||
| if (!req.session?.user?.id) { |
Member
Author
There was a problem hiding this comment.
Duplicate code - check is a few lines above
| export default async function handler(req: NextApiRequest, res: NextApiResponse) { | ||
| if (req.method === "POST") { | ||
| const command = req.body.command.split("/").pop(); | ||
| await slackVerify(req, res); |
Member
Author
There was a problem hiding this comment.
Slack dousing expect you to verify on commands - hence the verification failing
| view: CreateEventModal(data), | ||
| }); | ||
| res.status(200).end(); | ||
| return res.status(200).end(); |
Member
Author
There was a problem hiding this comment.
Was never returning here - Hence the timeout .... :(
zomars
reviewed
Jun 6, 2022
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
LGMT. Left just one comment
zomars
approved these changes
Jun 10, 2022
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Made some improvements. Feel free to retest and merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes slack timeout errors and verification failures and provides a more detailed error message to the user
Fixes #2970
Environment: Staging(main branch) / Production
Type of change
Checklist