Fix yarn dev and yarn dx from apps/web#3005
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jun 7, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
force-pushed
the
fix/dev-command
branch
from
2e2fd96 to
9ee24f6
Compare
hariombalhara
force-pushed
the
fix/dev-command
branch
from
c5e8393 to
f96ecfc
Compare
zomars
approved these changes
Jun 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3000
Bundles app-store:watch with apps/web#yarn dev and dx. Also, bundles app-store:generate with build and type-check from apps/web
Tests
yarn dev,yarn dx,yarn type-checkyarn dev,yarn dx,yarn type-checkFood for thought?
We manage most of the dependencies using turbo which doesn't come into the picture if the command is directly run from the package itself. So it means that we should manage the dependency in that case in the command itself. How should this be solved?