Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
suggested changes
Jun 8, 2022
apps/web/pages/[user]/book.tsx
Outdated
| periodStartDate: true, | ||
| periodEndDate: true, | ||
| recurringEvent: true, | ||
| requiresConfirmation: true, |
Contributor
There was a problem hiding this comment.
Let's take this opportunity to:
- Extract this commonly used select
- Put it in
packages/prisma/selects/event-types.ts - Use it instead instead of adding
requiresConfirmationindividually.
zomars
approved these changes
Jun 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@Jaibles added it requires confirmation UI here - Do you think we should display this here too?
Fixes #2997
Environment: Staging(main branch) / Production
Type of change
Checklist