Improvement: Add React to Embed Snippet Generator#3018
Merged
hariombalhara merged 7 commits intomainfrom Jun 9, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
force-pushed
the
feat/add-react-embed-generator
branch
2 times, most recently
from
c146e05 to
c38174c
Compare
hariombalhara
force-pushed
the
feat/add-react-embed-generator
branch
from
c38174c to
23fcc42
Compare
hariombalhara
changed the title
hariombalhara
force-pushed
the
feat/add-react-embed-generator
branch
from
3a42b76 to
0f303e6
Compare
hariombalhara
force-pushed
the
feat/add-react-embed-generator
branch
from
0f303e6 to
70c6a5f
Compare
hariombalhara
requested review from
PeerRich,
ciaranha,
emrysal and
zomars
and removed request for
zomars
hariombalhara
force-pushed
the
feat/add-react-embed-generator
branch
from
4fefef4 to
a06d78f
Compare
zomars
approved these changes
Jun 8, 2022
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Can't really say I know what's going on here. But code and demo looks good so... Approved!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add React to Embed Snippet Generator
Fixes #2961
Demo: https://www.loom.com/share/81c431512592416f917ae637900ce44e
Note that
Copy Codebutton is gone from Preview tab now as there can be 2 types of code to be copied now. So, theCopy Codebutton is specific to the tab now.Environment: Production
Type of change
How should this be tested?
Checklist