fix!: Booking Buttons doesn't display text#3033
Closed
gitstart wants to merge 3 commits intocalcom:mainfrom
Closed
fix!: Booking Buttons doesn't display text#3033gitstart wants to merge 3 commits intocalcom:mainfrom
gitstart wants to merge 3 commits intocalcom:mainfrom
Conversation
|
@gitstart is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Member
|
I think this should already be fixed with #3001 |
Member
|
fixed with #3001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2758
Type of change
How should this be tested?
Refer to this video:
https://www.loom.com/share/105113b860dd4fa2abd48b4ec3577586
Observation
This is a heavy-handed fix that works while Cal.com doesn't implement themes/dark mode at Dashboard level. The bug is caused by their current implementation of themes/dark mode at public pages level and implementing this feature at Dashboard level should fix the issue -- by that point, this bug fix should be removed, but until then, it passes the tests.