Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-brydon
commented
Jun 10, 2022
| lineThrough?: boolean; | ||
| }) => { | ||
| if (!props.description) return null; | ||
| if (!props.description || props.description=="") return null; |
Member
Author
There was a problem hiding this comment.
Some cases like additionlNotes are set to "" and was causing a random header to appear in the email field
| </p> | ||
| </div> | ||
| ); | ||
| if(props.attendee.email === props.calEvent.attendees[0].email || props.calEvent.organizer.email === props.attendee.email ){ |
Member
Author
There was a problem hiding this comment.
I switch this if statement cause I couldn't for the life of me to get it to work and I'm not sure why :S
Contributor
There was a problem hiding this comment.
Let's figure out why and take the learnings instead of just patching
Contributor
|
It wasn't ready to merge we found out some quirks on emails @baileypumfleet |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the organisers/attendee[0] to be given the option to manage the event - reschedule/cancel
Also hides info field if its an empty string. We were getting headings showing with no content (additional notes)
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
Checklist