Skip to content

Comments

Fix/stripe payment intent succeded#3044

Merged
zomars merged 5 commits intomainfrom
fix/stripe-payment-intent-succeded
Jun 13, 2022
Merged

Fix/stripe payment intent succeded#3044
zomars merged 5 commits intomainfrom
fix/stripe-payment-intent-succeded

Conversation

@alannnc
Copy link
Contributor

@alannnc alannnc commented Jun 12, 2022

What does this PR do?

  • Turns off conditional that validates if connected account is received in stripe request body from webhook and then throw error, but it is intended to have it. And adds stripe webhook secret as env key in env.example

Fixes # (issue)

Loom:
https://www.loom.com/share/590d22a2d0a04c6cbdd874d979448bdf

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a event type with a payment option
  • Go to schedule a booking on that event type, completing payment with credit card details
  • Go to your bookings and it should be listed as confirmed and accepted, and paid on DB.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Jun 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 7:12PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 13, 2022 at 7:12PM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 13, 2022 at 7:12PM (UTC)
ui ⬜️ Ignored (Inspect) Jun 13, 2022 at 7:12PM (UTC)

@alannnc alannnc requested a review from zomars June 12, 2022 20:33

if (event.account) {
throw new HttpCode({ statusCode: 202, message: "Incoming connected account" });
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was throwing 202 on my end and that body is received with an event.account value.

@alannnc alannnc requested a review from joeauyeung June 13, 2022 18:22
@alannnc alannnc marked this pull request as ready for review June 13, 2022 18:22
@zomars zomars merged commit 2362133 into main Jun 13, 2022
@zomars zomars deleted the fix/stripe-payment-intent-succeded branch June 13, 2022 19:41
zomars added a commit that referenced this pull request Jun 13, 2022
* Remove conditional that turned off booking payment update

* Added stripe webhook key to env vars

* Update .env.example

Co-authored-by: Omar López <zomars@me.com>
@zomars zomars mentioned this pull request Jun 15, 2022
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants