Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/web/components/App.tsx
Outdated
| email, | ||
| tos, | ||
| privacy, | ||
| multipleInstall = false, |
There was a problem hiding this comment.
New flag to know if an app can be installed multiple times
apps/web/components/App.tsx
Outdated
| {!isLoading ? ( | ||
| isGlobal || installedAppCount > 0 ? ( | ||
| <div className="space-x-3"> | ||
| {isLoading && <SkeletonButton width="24" height="10" />} |
There was a problem hiding this comment.
Changed ternary operation for explicit conditional
There was a problem hiding this comment.
What's wrong with the ternary?
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
I'd rather not add any more things to metadata as is going to be replace by the App model in the DB. Why not user the calendar category for now as it was before? Or there are any non-calendar apps that can be installed multiple times?
Co-authored-by: Leo Giovanetti <hello@leog.me>
Yeah, will switch to calendar instead then. Didn't know about upcoming AppModel in DB |
…al.com into fix/app-multiple-installs
5 participants
What does this PR do?
Fixed some conditionals on app page, to display that they can only be installed once and for calendars they can be installed multiple times
Fixes # (issue)
Loom Video: https://www.loom.com/share/2a35144a84f942418f75d916b7e668cd
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist