Skip to content

Missing calendar toggles fix#3066

Merged
zomars merged 4 commits intomainfrom
fix/added-calendar-toggles-missing
Jun 15, 2022
Merged

Missing calendar toggles fix#3066
zomars merged 4 commits intomainfrom
fix/added-calendar-toggles-missing

Conversation

@leog
Copy link
Contributor

@leog leog commented Jun 15, 2022

What does this PR do?

Brings back integrated calendar toggles missing due to a flag definition in a component

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Integrate a calendar (Apple, CalDav, etc) and see how the available calendars from those integrations now appear in the installed app page.

@leog leog requested a review from a team June 15, 2022 16:10
@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 4:33PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 15, 2022 at 4:33PM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 15, 2022 at 4:33PM (UTC)
ui ⬜️ Ignored (Inspect) Jun 15, 2022 at 4:33PM (UTC)

@leog leog added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Jun 15, 2022
@zomars zomars merged commit 6f8d052 into main Jun 15, 2022
@zomars zomars deleted the fix/added-calendar-toggles-missing branch June 15, 2022 16:35
@zomars zomars mentioned this pull request Jun 15, 2022
zomars added a commit that referenced this pull request Jun 15, 2022
* updates api submodule

* Fix credential creation flow for msteams app (#3029)

* Fix credential creation flow for msteams app

* Code review improve

* Fix preffer early returns

Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Flicker on booking success page (#3063)

* The booker get’s the Ui option to reschedule but can’t reschedule (#3061)

* Update CalendarService.ts (#3060)

* Revert "The booker get’s the Ui option to reschedule but can’t reschedule (#3061)"

This reverts commit 8cfc91d.

* New Crowdin translations by Github Action (#3065)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* Missing calendar toggles fix (#3066)

* onboarding flag fix

* Adjusting text + adding into locales file

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fixed flickering of more event name variables (#3069)

* Feature/booking page refactor (#3035)

* Extracted UI related logic on the DatePicker, stripped out all logic

* wip

* fixed small regression due to merge

* Fix alignment of the chevrons

* Added isToday dot, added onMonthChange so we can fetch this month slots

* Added includedDates to inverse excludedDates

* removed trpcState

* Improvements to the state

* All params are now dynamic

* This builds the flat map so not all paths block on every new build

* Added requiresConfirmation

* Correctly take into account getFilteredTimes to make the calendar function

* Rewritten team availability, seems to work

* Circumvent i18n flicker by showing the loader instead

* 'You can remove this code. Its not being used now' - Hariom

* Nailed a persistent little bug, new Date() caused the current day to flicker on and off

* TS fixes

* Fix some eventType details in AvailableTimes

* '5 / 6 Seats Available' instead of '6 / Seats Available'

* More type fixes

* Removed unrelated merge artifact

* Use WEBAPP_URL instead of hardcoded

* Next round of TS fixes

* I believe this was mistyped

* Temporarily disabled rescheduling 'this is when you originally scheduled', so removed dep

* Sorting some dead code

* This page has a lot of red, not all related to this PR

* A PR to your PR (#3067)

* Cleanup

* Cleanup

* Uses zod to parse params

* Type fixes

* Fixes ISR

* E2E fixes

* Disabled dynamic bookings until post v1.7

* More test fixes

* Fixed border position (transparent border) to prevent dot from jumping - and possibly fix spacing

* Disabled style nitpicks

* Delete useSlots.ts

Removed early design artifact

* Unlock DatePicker locale

* Adds mini spinner to DatePicker

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: zomars <zomars@me.com>

* v1.7.0

Co-authored-by: alannnc <alannnc@gmail.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com>
Co-authored-by: m4tze <m4tze@gmx.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Leo Giovanetti <hello@leog.me>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants