Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <Loader/> from app setup pages and team user availability view #4931

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Remove <Loader/> from app setup pages and team user availability view #4931

merged 6 commits into from
Oct 10, 2022

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

  • Removes loader from app setup pages
  • Replace old loader with skeleton loader for team user availability times
  • Add missing translations to team user availability

Loom Video: https://www.loom.com/share/35c396e4e8a441a9a74574fead01367e

Environment: Staging(main branch)

@CarinaWolli CarinaWolli requested a review from a team October 10, 2022 13:11
@vercel
Copy link

vercel bot commented Oct 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Oct 10, 2022 at 5:20PM (UTC)

PeerRich
PeerRich approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

zomars
zomars approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit 47e496f into main Oct 10, 2022
@zomars zomars deleted the fix/loader-setup-pages branch October 10, 2022 23:31
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
core area: core, team members only
Projects
No open projects
Cal.com Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarinaWolli @zomars @PeerRich