Fixes double bottom border in Integration List Item #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
commented
Oct 15, 2022
| const { componentMap, slug, ...rest } = props; | ||
|
|
||
| if (!componentMap[slug]) return null; | ||
|
|
||
| const Component = componentMap[slug]; | ||
|
|
||
| return <Component {...rest} />; | ||
| return ( | ||
| <div className={props.wrapperClassName || ""}> |
There was a problem hiding this comment.
Adds the className support through wrapper so that the app's AppSettings component never requires to read className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Notice the bottom border in case there are no App Settings
It was introduced here
11fee3a(#4998)