Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text editor for custom email bodies (custom workflow template) #5197

Closed
wants to merge 23 commits into from

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Adds a text editor to create better custom email bodies.

Screenshot 2022-10-25 at 11 23 54

Fixes:
First step of making workflow templates more flexible (#4944)

Loom Video: https://www.loom.com/share/a56df63342434a0a9727e8f770cc4c7b

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Create a new workflow with an email action
  • Test the custom email template as shown in the loom video

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 11:58AM (UTC)

@CarinaWolli CarinaWolli marked this pull request as draft October 25, 2022 09:31
@CarinaWolli CarinaWolli marked this pull request as ready for review October 25, 2022 10:15
@CarinaWolli CarinaWolli requested a review from a team October 25, 2022 10:15
Copy link
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it works! But I'm not sure about using a project that it's already on maintenance mode and soon to be archived.
Also we need to consider this:
image
Looks like it's no fully supported on ios or android.
They suggest to take a look on https://github.com/facebook/lexical

@CarinaWolli
Copy link
Member Author

But I'm not sure about using a project that it's already on maintenance mode and soon to be archived.
They suggest to take a look on https://github.com/facebook/lexical

I am trying out lexical right now, I'll make this PR a draft for now

@CarinaWolli CarinaWolli marked this pull request as draft October 28, 2022 06:41
@techquestions
Copy link

Please consider checking Slate and Quill. Both of these are production-ready editors/editor frameworks.

@CarinaWolli
Copy link
Member Author

Used facebook/lexical instead of draft.js #5654

@CarinaWolli CarinaWolli deleted the feat/wysiwyg-workflow-templates branch April 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants