Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds windows compatibility for copywebpackplugin #5602

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Nov 21, 2022

What does this PR do?

  • Attempts to add windows compatibility for CopyWebpackPlugin without destroying Mac compatibility

Fixes #4053

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 0:53AM (UTC)

@alishaz-polymath
Copy link
Member Author

E2E failing due to a test (has my url) timeout, should be unrelated to this PR I think 🤔
That feature works fine locally from the UI.

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work with Mac too :)

@emrysal emrysal merged commit 196549c into main Nov 21, 2022
@emrysal emrysal deleted the bugfix/copywebpack-windows-compat branch November 21, 2022 14:33
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants