-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe automatic payment method #6629
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@jepek is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dadcc3f
to
8fa6c39
Compare
hey @jepek, we'll look into this! thank you for the PR |
Deployment failed with the following error:
|
gave permission for a vercel deploymetn |
weird. deployment failed |
@PeerRich any reason from logs? |
somehow not |
9147818
to
76d0785
Compare
@PeerRich I rebased the branch on top of current |
Hey @zomars I see some conflicts now 👀 Do you have any idea why this fails? |
# Conflicts: # apps/web/pages/event-types/index.tsx # packages/app-store/ee/routing-forms/components/FormInputFields.tsx # packages/embeds/embed-core/package.json # packages/features/ee/common/components/LicenseRequired.tsx # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @jepek I was just testing this change an realized that this doesn't affect in any way with our current payment flow. Even I this is set to auto we still only display the Stripe Elements Credit Card field. We don't use Stripe Checkout anywhere which I assume this is what this parameters control.
Will close this for now but a more complete approach would be always welcome.
Thank you for your contribution 🙏
Hey @zomars I am back to the topic as I have another opportunity to integrate cal.com for one of my clients but I need the payment method via Stripe that they provide. I am not sure if this touches Stripe Checkout feature - I just want to activate one of the payment methods they are providing. I have tested a few calendar-booking solutions and some of them enable users to control by their own (via their Stripe account) the payment methods, some of them block this and pretend to do it in their behalf (what imo limits the usage) and some just locks the payment methods to the specific one as we have it here "cards" I think. I am sure this is only a matter of configuration because once some payment method is activated Stripe checkout handles that perfectly. @zomars Can we get back to this? Would be happy to work more on that. The thing that blocked us here was a failing preview branch. |
Hey, do we have any update on that? I'd like to integrate Polish payments (BLIK etc) but we're getting blocked by this. |
we are looking into this again! |
What does this PR do?
payment_method_types
in Stripe Payments lets clients to manage payments methods by them - they know best.automatic_payment_methods
(see the docs) improves the payment methods - Stripe will automatically propose payment methods based on currency/locale.Fixes #5263
This video from the Stripe Developers visually shows the difference
Type of change
Required actions ❗
Let connected accounts manage their payments methods:
Pleas see and follow the instructions here: https://stripe.com/docs/connect/automatic-payment-methods?connect-payment-integration-type=checkout&connect-charge-type=direct&connect-account-type=standard#allow-connected-accounts-manage
How should this be tested?
This changes the flow on the payment page from Stripe.
Additional
I wasn't able to publish self hosted version to test the custom payment methods from Stripe (they block it from local) thus preview instance and the change from Required actions would help a lot.