Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe automatic payment method #6629

Closed

Conversation

jepek
Copy link

@jepek jepek commented Jan 22, 2023

What does this PR do?

  1. Deleting payment_method_types in Stripe Payments lets clients to manage payments methods by them - they know best.
  2. Introducing automatic_payment_methods (see the docs) improves the payment methods - Stripe will automatically propose payment methods based on currency/locale.

Fixes #5263

This video from the Stripe Developers visually shows the difference

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Required actions ❗

Let connected accounts manage their payments methods:

Stripe recommends that you allow the owners of your platform’s connected accounts to customize their own payment methods from the Dashboard. If you enable this option, then each Standard connected account can log in to their Dashboard and view their Payment methods page.

Pleas see and follow the instructions here: https://stripe.com/docs/connect/automatic-payment-methods?connect-payment-integration-type=checkout&connect-charge-type=direct&connect-account-type=standard#allow-connected-accounts-manage

How should this be tested?

This changes the flow on the payment page from Stripe.

  • Check if other payment methods are available on payments page of connected account
  • Check if specific payments methods are available on payments page of connected account after customazing them under connected account payment methods

Additional

I wasn't able to publish self hosted version to test the custom payment methods from Stripe (they block it from local) thus preview instance and the change from Required actions would help a lot.

@vercel
Copy link

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Feb 8, 2023 at 7:54PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 7:54PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
cal-com-storybook ⬜️ Ignored (Inspect) Feb 8, 2023 at 7:54PM (UTC)

@vercel
Copy link

vercel bot commented Jan 22, 2023

@jepek is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@jepek jepek force-pushed the feature/stripe-automatic-payment-methods branch from dadcc3f to 8fa6c39 Compare January 22, 2023 22:32
@PeerRich PeerRich requested a review from zomars January 22, 2023 23:03
@PeerRich
Copy link
Member

hey @jepek, we'll look into this! thank you for the PR

@vercel
Copy link

vercel bot commented Jan 22, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@PeerRich
Copy link
Member

gave permission for a vercel deploymetn

@PeerRich
Copy link
Member

weird. deployment failed

@jepek
Copy link
Author

jepek commented Jan 23, 2023

@PeerRich any reason from logs?

@PeerRich
Copy link
Member

@PeerRich any reason from logs?

somehow not

@jepek jepek force-pushed the feature/stripe-automatic-payment-methods branch from 9147818 to 76d0785 Compare January 26, 2023 15:38
@jepek
Copy link
Author

jepek commented Jan 26, 2023

@PeerRich I rebased the branch on top of current main branch. Could you please approve the deployment to preview again?

@jepek
Copy link
Author

jepek commented Jan 29, 2023

Hey @zomars

I see some conflicts now 👀 Do you have any idea why this fails?

# Conflicts:
#	apps/web/pages/event-types/index.tsx
#	packages/app-store/ee/routing-forms/components/FormInputFields.tsx
#	packages/embeds/embed-core/package.json
#	packages/features/ee/common/components/LicenseRequired.tsx
#	yarn.lock
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @jepek I was just testing this change an realized that this doesn't affect in any way with our current payment flow. Even I this is set to auto we still only display the Stripe Elements Credit Card field. We don't use Stripe Checkout anywhere which I assume this is what this parameters control.

Will close this for now but a more complete approach would be always welcome.

Thank you for your contribution 🙏

@zomars zomars closed this Feb 8, 2023
@linear linear bot mentioned this pull request Feb 14, 2023
7 tasks
@jepek
Copy link
Author

jepek commented Oct 11, 2023

Hey @zomars

I am back to the topic as I have another opportunity to integrate cal.com for one of my clients but I need the payment method via Stripe that they provide.

I am not sure if this touches Stripe Checkout feature - I just want to activate one of the payment methods they are providing.

I have tested a few calendar-booking solutions and some of them enable users to control by their own (via their Stripe account) the payment methods, some of them block this and pretend to do it in their behalf (what imo limits the usage) and some just locks the payment methods to the specific one as we have it here "cards" I think. I am sure this is only a matter of configuration because once some payment method is activated Stripe checkout handles that perfectly.

@zomars Can we get back to this? Would be happy to work more on that. The thing that blocked us here was a failing preview branch.

@rushilsrivastava
Copy link

@PeerRich / @zomars

Same as @jepek mentioned above, we use Cal.com but are now considering switching over to other competitors because this feature is blocking us. Is this on the roadmap to fix?

@davidparys
Copy link

Hey, do we have any update on that? I'd like to integrate Polish payments (BLIK etc) but we're getting blocked by this.

@PeerRich
Copy link
Member

we are looking into this again!

@dosubot dosubot bot added this to the v4.2 milestone Apr 2, 2024
@dosubot dosubot bot modified the milestones: v4.2, v4.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3032] Allow other payment method types
6 participants