Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: placeholder in custom event name #7247

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

G3root
Copy link
Contributor

@G3root G3root commented Feb 21, 2023

What does this PR do?

Fixes #6591

after:
Screenshot 2023-02-21 at 15-10-29 30min Event Type Cal com

Screenshot 2023-02-21 15:09:38

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Feb 21, 2023 at 10:11AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Feb 21, 2023 at 10:11AM (UTC)

@G3root G3root requested a review from a team February 21, 2023 09:41
@@ -101,6 +101,11 @@ export const EventAdvancedTab = ({ eventType, team }: Pick<EventTypeSetupProps,
}
}, [eventType.customInputs]);

const eventNamePlaceholder = t("meeting_with_user")
.replace("{Event type title}", eventNameObject.eventType)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed those changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 213.33 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/event-types/[type] 266.06 KB 479.39 KB 136.97% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Feb 23, 2023
@kodiakhq kodiakhq bot merged commit b018ee3 into main Feb 23, 2023
@kodiakhq kodiakhq bot deleted the fix-default-value-custom-event-name branch February 23, 2023 15:46
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Feb 26, 2023
* fix: replace placeholder

* refactor: replace placeholder into a separate function
Mythie pushed a commit to Mythie/cal.com that referenced this pull request Mar 5, 2023
* fix: replace placeholder

* refactor: replace placeholder into a separate function
dmkav pushed a commit to join-com/cal-com that referenced this pull request Mar 6, 2023
* fix: replace placeholder

* refactor: replace placeholder into a separate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
2 participants