Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-admin team preview button #7301

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix non-admin team preview button #7301

merged 1 commit into from
Feb 23, 2023

Conversation

Hybes
Copy link
Contributor

@Hybes Hybes commented Feb 23, 2023

fix the non admin preview button taking you to an invalid URL with [id] in the URL

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Act as a user in a team, that's not an admin or owner, go to the Team -> Profile page in Settings. and click preview - the URL is wrong, then try after my PR and it's right - the copy link also uses this feature and worked before, but that still works in this.

Checklist

  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@Hybes Hybes requested a review from zomars as a code owner February 23, 2023 15:21
@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Feb 23, 2023 at 3:21PM (UTC)

@vercel
Copy link

vercel bot commented Feb 23, 2023

@Hybes is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

@zomars zomars merged commit 207bcb9 into calcom:main Feb 23, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Feb 26, 2023
Mythie pushed a commit to Mythie/cal.com that referenced this pull request Mar 5, 2023
dmkav pushed a commit to join-com/cal-com that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants