-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make embed tests work with single playwright config #7781
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed snapshots till we fix snapshot comparison |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,7 @@ if (IS_EMBED_REACT_TEST) { | |
|
||
const config: PlaywrightTestConfig = { | ||
forbidOnly: !!process.env.CI, | ||
retries: 2, | ||
retries: process.env.CI ? 2 : 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like tests to not retry locally so that the failure reason can be seen quickly. Also, I believe it also allows a flake to be detected easily. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not disable retires altogether so tests fail fast on CI? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because on CI it's too flaky to run without retries due to parallel runners. On dev it's more likely you are running only a single test or a few. |
||
workers: os.cpus().length, | ||
timeout: DEFAULT_TEST_TIMEOUT, | ||
maxFailures: headless ? 10 : undefined, | ||
|
@@ -102,13 +102,13 @@ const config: PlaywrightTestConfig = { | |
name: "@calcom/embed-core", | ||
testDir: "./packages/embeds/embed-core/", | ||
testMatch: /.*\.(e2e|test)\.tsx?/, | ||
use: { ...devices["Desktop Chrome"] }, | ||
use: { ...devices["Desktop Chrome"], baseURL: "http://localhost:3100/" }, | ||
}, | ||
{ | ||
name: "@calcom/embed-react", | ||
testDir: "./packages/embeds/embed-react/", | ||
testMatch: /.*\.(e2e|test)\.tsx?/, | ||
use: { ...devices["Desktop Chrome"] }, | ||
use: { ...devices["Desktop Chrome"], baseURL: "http://localhost:3101/" }, | ||
}, | ||
{ | ||
name: "@calcom/embed-core--firefox", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented these snapshots, they were never compared. But I plan to work on logic to compare them.