Fix warning for Ruby 2.7 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I18n.t defined as follows: ``` def translate(key = nil, *, throw: false, raise: false, locale: nil, **options) ``` With Ruby 2.7, we need to be explicit to pass in double splat options. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
|
Thanks! |
This was referenced May 10, 2020
gabebw
added a commit
to hotline-webring/hotline-webring
that referenced
this pull request
Jul 2, 2020
We need this PR to prevent warnings from Ruby 2.7: calebhearth/title#19 Until a new version is released, grab the code directly from GitHub.
gabebw
added a commit
to hotline-webring/hotline-webring
that referenced
this pull request
Jul 2, 2020
We need this PR to prevent warnings from Ruby 2.7: calebhearth/title#19 Until a new version is released, grab the code directly from GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the warning with Ruby 2.7 (similar to ruby-i18n/i18n#486).
I18n.tdefined as follows:With Ruby 2.7, we need to be explicit to pass in double splat options. Otherwise warning will be thorwn:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0
Tested on my rails app that this PR removed the warning.