Feature: Allow Sushi to work even when there is no data available. #84
Conversation
|
Hey Sam! Hope you don't mind me jumping in... how about hijacking the existing https://github.com/squirephp/squire/blob/main/packages/model/src/Model.php#L124-L126 |
|
Hey Dan, thanks for your comment - great idea! I'll update that now 😊 |
|
@danharrin are you interested in PRing your update to Sushi core? |
|
@calebporzio I updated this PR with Dan's schema logic. Do we need a |
|
I need this functionality and this is a really neat implementation, +1 for merging. |
|
We need this feature as well, as new users have empty API repositories. Is the merge conflict easily solvable? |
|
@calebporzio This PR had some merge conflicts which I have now resolved. |
|
@calebporzio would be great to see this feature in the sushi core. We also experience problems with getRow() and empty api respones. |
|
Great, thanks for the nudge. I agree 👌 |
|
Thanks for merging @calebporzio 🤘 |
|
@calebporzio Would it be possible to create a release for composer? <3 |
|
Done, tagged: v2.2.0 |
After introducing sushi to our project, our monitoring tool reported the following error (stacktrace shortened for brevity): ``` PDOException: SQLSTATE[HY000]: General error: 1 table "schmelzkurve_scoring_table_results" already exists #88 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(485): PDOStatement::execute #87 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(485): Illuminate\Database\Connection::Illuminate\Database\{closure} #86 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(685): Illuminate\Database\Connection::runQueryCallback #85 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(652): Illuminate\Database\Connection::run #84 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(486): Illuminate\Database\Connection::statement #83 /vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php(109): Illuminate\Database\Schema\Blueprint::build #82 /vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php(365): Illuminate\Database\Schema\Builder::build #81 /vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php(228): Illuminate\Database\Schema\Builder::create #80 /vendor/calebporzio/sushi/src/Sushi.php(142): App\Models\SchmelzkurveScoringTableResult::createTable #79 /vendor/calebporzio/sushi/src/Sushi.php(89): App\Models\SchmelzkurveScoringTableResult::migrate #78 /vendor/calebporzio/sushi/src/Sushi.php(45): App\Models\SchmelzkurveScoringTableResult::Sushi\{closure} #77 /vendor/calebporzio/sushi/src/Sushi.php(66): App\Models\SchmelzkurveScoringTableResult::bootSushi ``` This error can happen in rare circumstances due to a race condition. Concurrent requests may both see the necessary preconditions for the table creation, but only one can actually succeed. My initial attempt at resolving this was to look for a method that creates the table only if it does not exist (`create table if not exists`), but Laravel exposes no such method. Thus, I think the only viable solution is to risk it and catch the resulting error.
Hi Caleb 👋
Thank you for Sushi, I really love using it.
I recently ran into a scenario where I was using
getRows()to grab data from a third party API, but sometimes the API would return an empty array as its results. Looking into the Sushi trait, it looks like it depends on at least one row of data to be within the array, because it uses that row to work out the column structure.To get around this, I wrote two new methods that are invoked on the
migrate()method. One iscreateTableand the other iscreateTableWithNoData. If there happens to be no rows available, this will look for a newprotected $columnswhere you can define your own table structure, all within the model! I've used the same data types that you had in your originalmigrate()command to ensure compatibility.I also built a simple test for this too, but I'd love to know your thoughts.