Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSHAgent and Key Types outside of RSA #227

Merged
merged 2 commits into from
Dec 26, 2021

Conversation

calebstewart
Copy link
Owner

Description of Changes

This PR overhauls the SSH channel implementation to more correctly utilize Paramiko, and also moves our dependency from paramiko to paramiko-ng, which provides fixes for previously broken parts of paramiko.

This not only simplifies the SSH channel implementation, but also means that SSH-Agent should work out of the box and that you can now use keys aside from RSA (tested with an ed25519 key).

Fixes #91.

Major Changes Implemented:

  • Replaced paramiko with paramiko-ng
  • Utilized Paramiko SSHClient which will also utilize the SSHAgent if available by default and supports key types aside from RSA (#91)

Pre-Merge Tasks

  • Formatted all modified files w/ python-black
  • Sorted imports for modified files w/ isort
  • Ran flake8 on repo, and fixed any new problems w/ modified files
  • Ran pytest test cases
  • Added brief summary of updates to CHANGELOG (under [Unreleased])

For issues with pre-merge tasks, see CONTRIBUTING.md

@calebstewart calebstewart merged commit 6a913f0 into master Dec 26, 2021
@calebstewart calebstewart deleted the issue-91-paramiko-ng branch December 26, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for ssh-agent for ssh authentication
1 participant