Suggestion for Package Setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added an abstract base class for ErrorType, refined the low_level api a bit and implemented a Mojibake ErrorType. The code currently doesn't work and needs to be fixed a bit, but the general idea should be clear. --------- Co-authored-by: Sebastian Jäger <git@sebastian-jaeger.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then main change is that I downgraded to 3.9 because not all packages support 3.12 already. This would cause problems when someone requires this package and another one depending on python<3.12. See: https://pyreadiness.org/3.12/
Further, I added mypy and its pre-commit hook.
The changes I made for the ruff settings are mainly using its formatter, fix the rules if possible, apply all rules to ipynb notebooks, enforce google pydocs, and removed many of the ignores rules. Also there are some code changes that fix those issues.
Lastly, there are some GH actions running ruff and mypy (with python 3.0 to 3.11) over PRs in case someone skipped the pre-commit hooks. The printed issues will be shown inline in the
Files changedtab.