Add Butterfinger, change the API #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-jung
force-pushed
the
feat/butterfinger
branch
from
aabd16b to
fc99336
Compare
This was intended to add the Butterfinger error type, which it does. It also completely changes how ErrorMechanism and ErrorType is configured. The idea is that the abstract base classes ErrorMechanism and ErrorType become stateful, and that they are configured upon initialization. I made this change because I figured that ErrorTypes need to be configured with configurations that are very different. Having a dataclass that stores that configuration allows us to control all parameters in one place, which is handy when adding more ErrorTypes in the future I believe. This does change however how error_generation can be used, check the samples.ipynb for reference.
philipp-jung
force-pushed
the
feat/butterfinger
branch
from
fc99336 to
4f9bab1
Compare
Make it so that the ErrorMechanism Objects take up to two arguments when being created, and not a config-Object, which is a bit weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to add the Butterfinger error type, which it does. It also completely changes how ErrorMechanism and ErrorType is configured.
The idea is that the abstract base classes ErrorMechanism and ErrorType become stateful, and that they are configured upon initialization.
I made this change because I figured that ErrorTypes need to be configured with configurations that are very different. Having a dataclass that stores that configuration allows us to control all parameters in one place, which is handy when adding more ErrorTypes in the future I believe.
This does change however how error_generation can be used, check the samples.ipynb for reference.