Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calian updates to sdnotify #1

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Calian updates to sdnotify #1

merged 4 commits into from
Oct 18, 2024

Conversation

zack-mayoh
Copy link
Collaborator

@zack-mayoh zack-mayoh commented Oct 15, 2024

  • Added/updated copyright info
  • Renamed to async-sdnotify
  • Updated type annotations
  • Converted to Poetry project
  • Wrote unit tests for 100% test coverage:
============================= test session starts ==============================
platform linux -- Python 3.11.7, pytest-8.3.3, pluggy-1.5.0 -- /home/mayoh/async-sdnotify/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/mayoh/async-sdnotify
configfile: pyproject.toml
plugins: asyncio-0.24.0, cov-5.0.0
asyncio: mode=Mode.STRICT, default_loop_scope=None
collecting ... collected 5 items

tests/test_systemdnotifier.py::test_does_nothing_without_environment PASSED [ 20%]
tests/test_systemdnotifier.py::test_connect_throws_exception_when_debug PASSED [ 40%]
tests/test_systemdnotifier.py::test_status_throws_exception_when_debug PASSED [ 60%]
tests/test_systemdnotifier.py::test_start_watchdog_throws_exception_when_debug PASSED [ 80%]
tests/test_systemdnotifier.py::test_sends_notifications PASSED           [100%]

---------- coverage: platform linux, python 3.11.7-final-0 -----------
Name                      Stmts   Miss  Cover
---------------------------------------------
aiosdnotify/__init__.py      82      0   100%
---------------------------------------------
TOTAL                        82      0   100%
Coverage XML written to file coverage.xml


============================== 5 passed in 1.06s ===============================
Finished running tests!

- Update references to package name in README
- Update License and Copyright
Add configuration to use Poetry instead of setuptools
@zack-mayoh zack-mayoh marked this pull request as ready for review October 15, 2024 21:05
@zack-mayoh zack-mayoh self-assigned this Oct 15, 2024
@zack-mayoh zack-mayoh requested a review from AmrJll October 15, 2024 21:13
aiosdnotify/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bwillenborg bwillenborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change asyncio.Task[Any] to asyncio.Task[None].

aiosdnotify/__init__.py Outdated Show resolved Hide resolved
tests/test_systemdnotifier.py Outdated Show resolved Hide resolved
Add missing type annotations and fix mismatched type issues
Gets SystemdNotifier to 100% test coverage.
@zack-mayoh zack-mayoh merged commit a34a4c0 into main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants