Fix profiles parameter not being passed for site metrics, update CLI option descriptions
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated descriptions on pages, profiles and metrics to include default behaviour when not set.
|
|
|
@jonogillettt Thanks for the PR! We'll get this merged and release a new version 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
--helpoutput says that you can provide--profilesarguments to the CLI to filter the metrics to the desired Test Profiles, however that argument is not respected as it does not get passed to the GraphQL query.This change simply passes the
profilescommand line argument through to the TimeSerieslistcall which already supports it.Additionally updated the CLI
optionsdescriptions to markpagesandprofilesas array types since they accept multiple values.Also added text to the descriptions of
pages,profilesandmetricsdescribing default behaviour when not set in the same form as thefromandtooptions.