-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic admin site #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xilosada
force-pushed
the
xabi/basic-admin
branch
from
March 26, 2024 10:25
6d04dc4
to
0e01086
Compare
xilosada
commented
Mar 26, 2024
xilosada
commented
Mar 26, 2024
xilosada
commented
Mar 26, 2024
xilosada
commented
Mar 26, 2024
xilosada
commented
Mar 26, 2024
I still don't have a final decission about adding the dist folder as an asset and regenerate it in the pipeline. |
miraclx
reviewed
Mar 27, 2024
xilosada
force-pushed
the
xabi/basic-admin
branch
from
March 27, 2024 12:11
283010f
to
01b3172
Compare
chefsale
approved these changes
Mar 27, 2024
xilosada
force-pushed
the
xabi/basic-admin
branch
from
March 27, 2024 18:06
8bd032c
to
f7b68e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
First go to node-ui folder and build the site:
pnpm install && pnpm build
for development you can just run the site using
pnpm dev
Once the dist folder is created run the node and navigate to
http://127.0.0.1:2428/admin/
Screen.Recording.2024-03-26.at.11.21.11.AM.mov