feat(node+server): query proposals #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frdomovic
changed the title
miraclx
reviewed
Nov 13, 2024
Comment on lines
+62
to
+69
| println!("{:#?}", proposal); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Report for GetProposalResponse { | ||
| fn report(&self) { | ||
| println!("{:#?}", self.data.report()); | ||
| println!("{:#?}", self.data); |
There was a problem hiding this comment.
should we remove Report impl for Proposal then?
miraclx
reviewed
Nov 13, 2024
miraclx
reviewed
Nov 13, 2024
crates/context/config/src/client/env/proxy/query/proposal_approvers.rs
Outdated
Show resolved
Hide resolved
miraclx
reviewed
Nov 14, 2024
miraclx
reviewed
Nov 14, 2024
miraclx
reviewed
Nov 14, 2024
crates/context/config/src/client/env/proxy/query/proposal_approvers.rs
Outdated
Show resolved
Hide resolved
miraclx
approved these changes
Nov 14, 2024
miraclx
reviewed
Nov 14, 2024
miraclx
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(node+server): query proposals
Summary:
Updated logic for querying proposal data and setup logic functions in contract manager to connect with admin api calls.
Also updated blockchain app logic so it returns proposal id when creating a new proposal