Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): icp integration #986

Merged
merged 123 commits into from
Dec 7, 2024
Merged

feat(node): icp integration #986

merged 123 commits into from
Dec 7, 2024

Conversation

frdomovic
Copy link
Member

@frdomovic frdomovic commented Nov 26, 2024

feat(node): icp integration

Summary

Complete ICP integration including:

  • new protocol in the process of node initialisation (--protocol icp)
  • generic ICP code for query and mutate
  • updated for context config contract query + mutate methods (types encode and decode for ICP)
  • updated for proxy contract query + mutate methods (types encode and decode for ICP)

@frdomovic frdomovic force-pushed the icp_query_mutate_integration branch from d37bf0e to 1133242 Compare November 27, 2024 16:21
@frdomovic frdomovic changed the base branch from master to feat--icp-contracts November 28, 2024 12:07
@miraclx miraclx changed the base branch from master to miraclx/dedupe-types December 5, 2024 20:44
@miraclx miraclx changed the base branch from miraclx/dedupe-types to master December 5, 2024 20:48
Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good

crates/merod/src/cli/relay.rs Outdated Show resolved Hide resolved
Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frdomovic
Copy link
Member Author

@miraclx @alenmestrov reverted proxy query to Principal + updated encoding , tested so merging this PR.
Screenshot 2024-12-07 at 02 35 07

@frdomovic frdomovic merged commit ec9a724 into master Dec 7, 2024
11 checks passed
@frdomovic frdomovic deleted the icp_query_mutate_integration branch December 7, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants